Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same pixi version on all of CI (0.20.0) #6088

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 23, 2024

Checklist

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

Deployed docs

Commit Link
3342a9d https://landing-mov2ylrwi-rerun.vercel.app/docs

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh so those got missed on a recent update round?

Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to happen again and again. We should use a GHA variable for this: https://github.com/rerun-io/rerun/settings/variables/actions

@emilk
Copy link
Member Author

emilk commented Apr 24, 2024

huh so those got missed on a recent update round?

Nope, I seem to get a different pixi.lock than everyone else, because the CI hates my new pixi.lock

@jleibs
Copy link
Member

jleibs commented Apr 24, 2024

We should use a GHA variable for this

The one challenge with this is that it can't be updated atomically as part of a PR in conjunction with with pixi.toml / pixi.lock. There may be future pixi versions that require this change so there will be a bit of an annoying dance to maneuver when that happens.

Could be worth seeing if there is a way to always seed global environment variables from a single config file at the root of the repo.

@emilk emilk changed the title Use same pixi version on all of CI (0.19.1) Use same pixi version on all of CI (0.20.0) Apr 24, 2024
@emilk
Copy link
Member Author

emilk commented Apr 24, 2024

I'm not sure what this is

Screenshot 2024-04-24 at 14 53 02

@Wumpf
Copy link
Member

Wumpf commented Apr 24, 2024

that's an alias @jleibs introduced yesterday. but why is it not found Oo.
Maybe just need to merge in main?

@emilk
Copy link
Member Author

emilk commented Apr 24, 2024

This is going to happen again and again. We should use a GHA variable for this: https://github.com/rerun-io/rerun/settings/variables/actions

Sounds like a fun journey for another day

@emilk emilk requested a review from teh-cmc April 24, 2024 18:15
@teh-cmc teh-cmc removed their request for review April 25, 2024 07:08
@emilk emilk merged commit 45ec26a into main Apr 25, 2024
39 checks passed
@emilk emilk deleted the emilk/update-pixi-lock branch April 25, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants