Fix unnecessary re_viewer dependency #6369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The mechanism for identifying Rerun clients was implemented in #6204. However, during the release I accidentally "fixed" the build of
cargo build -p re_viewer --no-default-features
twice:re_sdk_comms
with theserver
feature always enabled.re_sdk_comms
server errors with#[cfg(feature = "server")]
. Butre_viewer
doesn't have aserver
feature, disabling this effectively. This was reverted in Don't log warnings when unknown clients connect over TCP #6368It's up to users of
re_viewer
to allow the serve feature, makingre_viewer
agonistic of the presence of this error type in its smart channel. Therefore I now moved out the error type tore_sdk_comms
lib.rs so thatre_viewer
doesn't have to depend on there_sdk_comms
's server feature.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.