Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix welcome screen header jumping during load #6389

Merged
merged 1 commit into from
May 21, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 20, 2024

What

The centering was wrong until the examples has finished loading, leading to it jumping, especially on slow internet connections.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface include in changelog labels May 20, 2024
@emilk emilk merged commit 37fd367 into main May 21, 2024
36 checks passed
@emilk emilk deleted the emilk/fix-glitchy-welcome-screen branch May 21, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant