Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use literal unions in python enum codegen #6408

Merged
merged 10 commits into from
May 22, 2024
Merged

Use literal unions in python enum codegen #6408

merged 10 commits into from
May 22, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented May 22, 2024

What

Strings now autocomplete in places where we use enum classes that get converted from strings.

Follow up to #6407

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

Copy link

github-actions bot commented May 22, 2024

Deployed docs

Commit Link
970bcab https://landing-45oyyhziw-rerun.vercel.app/docs

@jprochazk jprochazk marked this pull request as draft May 22, 2024 16:47
@jprochazk jprochazk force-pushed the jan/py-enum-codegen branch from 37370fc to 970bcab Compare May 22, 2024 16:54
@jprochazk jprochazk marked this pull request as ready for review May 22, 2024 16:56
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we had a bit a discussion about casing/style of the enum values and ended up with this here)

👍

@jprochazk jprochazk merged commit 0270109 into main May 22, 2024
35 checks passed
@jprochazk jprochazk deleted the jan/py-enum-codegen branch May 22, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants