Fix error when logging segmentation image #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
commented
May 28, 2024
Wumpf
commented
May 28, 2024
| @@ -560,12 +560,14 @@ impl ImageVisualizer { | |||
| let tensor_stats = ctx | |||
| .cache | |||
| .entry(|c: &mut TensorStatsCache| c.entry(tensor_data_row_id, tensor)); | |||
| let depth_texture = re_viewer_context::gpu_bridge::depth_tensor_to_gpu( | |||
| let depth_texture = re_viewer_context::gpu_bridge::tensor_to_gpu( | |||
There was a problem hiding this comment.
not exposing the inner methods of tensor_to_gpu is nice from a crate isolation perspective & doesn't cause any overhead here :). This callsite was the only one that needed adjustment
Wumpf
force-pushed
the
andreas/annotation-context-log-issue
branch
from
597d961 to
ca2338b
Compare
abey79
approved these changes
May 28, 2024
emilk
reviewed
May 28, 2024
emilk
reviewed
May 28, 2024
abey79
pushed a commit
that referenced
this pull request
May 29, 2024
* Fixes #6443 * the problem was that we use row ids for hashing texture manager entries. Instead, we need to use a combination of texture meaning + row id, because the same row may give rise to several textures! * Fixes this also for any other combination of textures on the same row (e.g. depth + regular) * Fixes bad error message display * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6449?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6449?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6449) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.