-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All components implement the Default
trait now in Rust
#6458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
changed the title
All components implement the
All components implement the May 30, 2024
Default
now in RustDefault
trait now in Rust
emilk
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! But we should be careful when picking the defaults, and err on the side of explicit
crates/re_types/definitions/rerun/blueprint/components/visual_bounds2d.fbs
Outdated
Show resolved
Hide resolved
crates/re_types/definitions/rerun/components/clear_is_recursive.fbs
Outdated
Show resolved
Hide resolved
crates/re_types/definitions/rerun/components/pinhole_projection.fbs
Outdated
Show resolved
Hide resolved
…ter all after seeing how it affects examples negatively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
initial_override_value
with a "FallbackProvider" trait which can be used for edit_ui #6434While working on
ComponentFallbackProvider
for highly customized & context dependent fallback value generation (which can be used by ui, views and visualizer alike to ensure they all see the same data in the case of absent data) I noticed that:In order to get this "bottom fallback" @jleibs and me decided after some back and forth to simply implement the
Default
trait for all component types. This is enforced by a new generated method,list_default_components
which is part ofre_viewer
and will be in a follow-up pr used to populate a "component fallback registry".Alternatives considered: Originally I used this construct to distinguish
Default
from potentially non-sensical fallbacks. But I eventually discarded this as too overenginered:Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.