Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fullscreen mode to web viewer #6461

Merged
merged 23 commits into from
May 31, 2024
Merged

Add fullscreen mode to web viewer #6461

merged 23 commits into from
May 31, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented May 30, 2024

What

This PR enables the ToggleFullscreen UI command for web target, implemented in JS land. The functionality is also exposed via the toggle_fullscreen method. Callbacks are used to communicate about fullscreen state between WASM and JS.

To test, you'll need to build branch fullscreen-temp of https://github.com/rerun-io/web-viewer-example with a globally linked web-viewer package built from source:

  1. Install Yarn: npm i -g yarn
  2. In this repository:
    • yarn --cwd rerun_js install
    • yarn --cwd rerun_js/web-viewer build
    • yarn --cwd rerun_js/web-viewer link
  3. In the web-viewer-example repository:
    • yarn
    • yarn link @rerun-io/web-viewer
    • yarn dev + open the page

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jprochazk jprochazk added 🕸️ web regarding running the viewer in a browser include in changelog labels May 30, 2024
@jprochazk jprochazk changed the title Web: Fullscreen mode Add fullscreen mode to web viewer May 30, 2024
@jprochazk jprochazk marked this pull request as ready for review May 31, 2024 11:05
crates/re_viewer/src/app.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/app.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/app.rs Outdated Show resolved Hide resolved
@jprochazk
Copy link
Member Author

link checker failure is unrelated

@jprochazk jprochazk merged commit 9ece5dd into main May 31, 2024
33 of 34 checks passed
@jprochazk jprochazk deleted the jan/web-fullscreen branch May 31, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen mode on web
2 participants