-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fullscreen mode to web viewer #6461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
added
🕸️ web
regarding running the viewer in a browser
include in changelog
labels
May 30, 2024
emilk
approved these changes
May 31, 2024
link checker failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR enables the
ToggleFullscreen
UI command for web target, implemented in JS land. The functionality is also exposed via thetoggle_fullscreen
method. Callbacks are used to communicate about fullscreen state between WASM and JS.To test, you'll need to build branch
fullscreen-temp
of https://github.com/rerun-io/web-viewer-example with a globally linkedweb-viewer
package built from source:npm i -g yarn
yarn --cwd rerun_js install
yarn --cwd rerun_js/web-viewer build
yarn --cwd rerun_js/web-viewer link
web-viewer-example
repository:yarn
yarn link @rerun-io/web-viewer
yarn dev
+ open the pageChecklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.