Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pixi.toml to use rerun_py package directly #6466

Merged
merged 5 commits into from
May 31, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented May 30, 2024

What

Our shim package broke with the update to pixi 0.22.

However, pixi now mostly does the correct thing with a source install of the rerun_py package, so we now use that instead of the shim package.

I introduced a new python-dev feature which is used for pulling in the dev version of rerun. The upside of this is it opens up another feature variant examples-pypi which uses the published version of rerun.

We should be able to do something similar with the wheel package as well.

Lastly, I had to re-generate our lockfile to get around some weird issues with tzdata. This bumped the lockfile version, which means dragging everyone forward to pixi 0.23

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🧑‍💻 dev experience developer experience (excluding CI) 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 30, 2024
Copy link

github-actions bot commented May 30, 2024

Deployed docs

Commit Link
762f51e https://landing-dr1lb5g0q-rerun.vercel.app/docs

@jleibs jleibs marked this pull request as ready for review May 30, 2024 20:46
@jleibs jleibs requested review from abey79 and removed request for abey79 May 30, 2024 20:49
pixi/maturin_config.sh Show resolved Hide resolved
@emilk emilk mentioned this pull request May 31, 2024
5 tasks
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeeee, I can build again 🙏

@teh-cmc
Copy link
Member

teh-cmc commented May 31, 2024

@rerun-bot full-check

Copy link

@teh-cmc teh-cmc merged commit ea4fc10 into main May 31, 2024
73 checks passed
@teh-cmc teh-cmc deleted the jleibs/rerun_examples_pixi branch May 31, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants