Better integration of ListItem in tooltips and other popups
#6486
Conversation
emilk
added
blocked
emilk
force-pushed
the
emilk/prevent-list-item-expansion
branch
from
d9d0781 to
d8f8f2b
Compare
This ensures tooltips with `ListItem`s don't get unnecessarily wide
emilk
force-pushed
the
emilk/prevent-list-item-expansion
branch
from
c8cc940 to
805811f
Compare
# Conflicts: # crates/re_data_ui/src/item_ui.rs # crates/re_time_panel/src/lib.rs # crates/re_ui/src/lib.rs # crates/re_ui/src/list_item/label_content.rs # crates/re_ui/src/list_item/list_item.rs # crates/re_ui/src/list_item/mod.rs
emilk
added
the
exclude from changelog
| // avoid the list item to max the tooltip width | ||
| if ui_layout == UiLayout::Tooltip { | ||
| content = content.exact_width(true); | ||
| } |
There was a problem hiding this comment.
This is now detected automagically by PropertyContent
| @@ -626,7 +626,7 @@ impl TimePanel { | |||
| ctx, | |||
| &InstancePath::from(tree.path.clone()), | |||
| )) | |||
| .exact_width(true), | |||
| .truncate(false), | |||
There was a problem hiding this comment.
We don't yet magically detect that we are in the time panel, so we still need to tell the contents not to truncate here
| @@ -417,8 +417,7 @@ pub fn component_path_button_to( | |||
| } else { | |||
| "Temporal component" | |||
| }) | |||
| .with_icon(icon) | |||
| .exact_width(true), | |||
There was a problem hiding this comment.
again, the contents magically knows not to truncate when in a tooltip
emilk
changed the title
ListItem in tooltipsListItem in tooltips and other popups
crates/re_ui/src/lib.rs
Outdated
| /// Used as a heuristic to figure out if it is safe to truncate text. | ||
| /// | ||
| /// If this returns false, we should never truncate. |
There was a problem hiding this comment.
If this returns false, we should never truncate.
Double-negative. Would be easier to follow as "If this returns true, we should truncate text when necessary."
The rationale coupling this description to the name of the function still isn't totally obvious. Even if a panel is not resizable, if the text is much longer than the available (non-resizable) panel size, it seems like truncation could be necessary.
There was a problem hiding this comment.
I expanded the docstring to clarify
What
ListItemin tooltips #6516This PR lets us put any
ListItemanywhere without trouble.This is because of two things:
ListItemunderstands the concept of an egui sizing pass, so won't expand to become huge when in a tooltipLabelContentandPropertyContentcan tell when it is in a tooltip, and in these cases won't truncate the contentsChecklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.