Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing visual bounds from ui #6492

Merged
merged 14 commits into from
Jun 5, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 4, 2024

What

This also introduces the concept of multiline editors - didn't want to split it out since then I'd be lacking a working example for it, but commits are split along that falt line.
With introduction of multiline editors I refactored the view property ui functionality such that parts will be more reusable in the future.

bounds_editing2.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself include in changelog labels Jun 4, 2024
@Wumpf Wumpf force-pushed the andreas/generic-visual-bounds-ui branch from ad33ad6 to adee173 Compare June 4, 2024 12:00
@Wumpf Wumpf marked this pull request as draft June 4, 2024 12:46
@Wumpf Wumpf marked this pull request as ready for review June 4, 2024 13:02
@abey79 abey79 self-requested a review June 4, 2024 13:31
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff again!

crates/re_viewer_context/src/component_ui_registry.rs Outdated Show resolved Hide resolved
crates/re_viewer_context/src/component_ui_registry.rs Outdated Show resolved Hide resolved
crates/re_space_view/src/view_property_ui.rs Outdated Show resolved Hide resolved
crates/re_space_view/src/view_property_ui.rs Outdated Show resolved Hide resolved
response
}

pub fn singleline_edit_visual_bounds2d(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I'm wondering if whether we can is obscuring whether we should :) The UX is not bad, but a bit surprising. Let's see what people think about it—I'd remove it if it induces too much confusion.

@Wumpf Wumpf modified the milestone: #6237 Jun 4, 2024
@Wumpf Wumpf merged commit 9aa6645 into main Jun 5, 2024
19 checks passed
@Wumpf Wumpf deleted the andreas/generic-visual-bounds-ui branch June 5, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First draft of generic UI for space view properties
2 participants