-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow editing visual bounds from ui #6492
Conversation
ad33ad6
to
adee173
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff again!
response | ||
} | ||
|
||
pub fn singleline_edit_visual_bounds2d( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I'm wondering if whether we can is obscuring whether we should :) The UX is not bad, but a bit surprising. Let's see what people think about it—I'd remove it if it induces too much confusion.
What
This also introduces the concept of multiline editors - didn't want to split it out since then I'd be lacking a working example for it, but commits are split along that falt line.
With introduction of multiline editors I refactored the view property ui functionality such that parts will be more reusable in the future.
bounds_editing2.mp4
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.