Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option to enable/disable depth projection from ui #6550

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 12, 2024

What

This will soon be handled by enabling/disabling visualizers instead.
A sideeffect of this is that the option to change the depth image colormap also shows up in 2D views (as it should). But we're going to do a pass over how this ui is generated soon anyways which would have also caught this.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself include in changelog do-not-merge Do not merge this PR labels Jun 12, 2024
@Wumpf Wumpf force-pushed the andreas/remove-backproject-depth-option branch from a67c82c to b8927c2 Compare June 12, 2024 15:04
Base automatically changed from andreas/split-depthimage-visualizer to main June 13, 2024 07:21
@Wumpf Wumpf force-pushed the andreas/remove-backproject-depth-option branch from b8927c2 to 0a93d7b Compare June 13, 2024 07:23
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Jun 13, 2024
@Wumpf Wumpf merged commit 284c761 into main Jun 13, 2024
34 of 35 checks passed
@Wumpf Wumpf deleted the andreas/remove-backproject-depth-option branch June 13, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants