Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong depth projection value on picking when depth meter was edited #6551

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 12, 2024

What

Previously, depth meter editing worked via the legacy EntityProperties, now it is a DepthMeter component override. Since EntityProperties wasn't always applied correctly, and #6549 makes queries to images during picking go through the blueprint layer, this fixes picking interaction

After:
image

Before, the same picking returned a different (wrong) depth value!)
image

Part of:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality include in changelog labels Jun 12, 2024
@Wumpf Wumpf force-pushed the andreas/remove-backproject-depth-option branch from b8927c2 to 0a93d7b Compare June 13, 2024 07:23
@Wumpf Wumpf force-pushed the andreas/remove-entityprops-depthmeter branch from a67c82c to 7865fef Compare June 13, 2024 07:23
Base automatically changed from andreas/remove-backproject-depth-option to main June 13, 2024 08:05
@Wumpf Wumpf force-pushed the andreas/remove-entityprops-depthmeter branch from 7865fef to c867d37 Compare June 13, 2024 08:11
Copy link

Deployed docs

Commit Link
c867d37 https://landing-ka2qcwx1a-rerun.vercel.app/docs

@Wumpf Wumpf merged commit 1218f12 into main Jun 13, 2024
34 checks passed
@Wumpf Wumpf deleted the andreas/remove-entityprops-depthmeter branch June 13, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants