Introduce ChunkStore::drop_entity_path
#6588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
⛃ re_datastore
teh-cmc
force-pushed
the
cmc/store_chunks_scratch
branch
from
014d5cb to
ad29d5c
Compare
teh-cmc
force-pushed
the
cmc/remove_entity_api
branch
from
4c2f210 to
8933d3a
Compare
jleibs
approved these changes
Jun 21, 2024
crates/re_chunk_store/src/writes.rs
Outdated
Comment on lines
223
to
230
| per_start_time | ||
| .into_values() | ||
| .flat_map(|chunk_ids| chunk_ids.into_iter()) | ||
| .chain( | ||
| per_end_time | ||
| .into_values() | ||
| .flat_map(|chunk_ids| chunk_ids.into_iter()), | ||
| ) |
There was a problem hiding this comment.
No harm in being thorough, but shouldn't every chunk_id occur both in per_start_time and per_end_time? Do we actually need to iterate both of them?
There was a problem hiding this comment.
Nah we don't, I went a bit overboard
|
Reminder to get rid of the |
teh-cmc
force-pushed
the
cmc/remove_entity_api
branch
from
8933d3a to
9bd4c62
Compare
teh-cmc
force-pushed
the
cmc/store_chunks_scratch
branch
from
7e789be to
1e24a6b
Compare
teh-cmc
force-pushed
the
cmc/remove_entity_api
branch
from
a02c43a to
07df663
Compare
teh-cmc
force-pushed
the
cmc/store_chunks_scratch
branch
from
56207f3 to
6b42567
Compare
teh-cmc
force-pushed
the
cmc/remove_entity_api
branch
from
07df663 to
e0fbd0f
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9795416503 |
teh-cmc
force-pushed
the
cmc/store_chunks_scratch
branch
from
6b42567 to
d304e97
Compare
teh-cmc
force-pushed
the
cmc/remove_entity_api
branch
from
64bf654 to
396555f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new API to drop an entity path in its entirety, unconditionally.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.