Add width/height properties to web viewer #6636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We now set the web viewer CSS width/height to some default values, which can be modified by the user. Setting them to empty strings is allowed to disable the default values completely, and allow styling the canvas through other means as before.
This is meant as a mitigation for emilk/egui#4699 - by setting the CSS width/height to something, the canvas width/height attributes won't contribute to the display size of the canvas.
Tested in https://github.com/rerun-io/web-viewer-example by manually linking the package
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.