Rewrite the ui.large_collapsing_header into re_ui::SectionCollapsingHeader using re_ui::ListItem
#6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added show_hierarchical_with_children_unindented to ListItem - Re-implemented LargeCollapsingHeader using ListItem
…ort for help tooltip
abey79
added
enhancement
abey79
changed the title
re_ui::SectionCollapsingHeader using re_ui::ListItemui.large_collapsing_header into re_ui::SectionCollapsingHeader using re_ui::ListItem
|
might be already on your radar: visible time range uses a long tool tip whereas the query uses the info button to convey what's in there |
Good call. adding this to #6655, I'll do it in a separate PR. |
Wumpf
reviewed
Jun 27, 2024
| .interactive(true) | ||
| .force_background(DesignTokens::section_collapsing_header_color()) | ||
| .show_hierarchical_with_children_unindented(ui, id, default_open, content, |ui| { | ||
| //TODO(ab): this space is not desirable when the content actually is list items |
There was a problem hiding this comment.
probably link to the list itemification ticket? Once everything is linst items it should go away
On that note: Now that this is a list item, does it mean that we can remove some of the list item scopes we add down the line?
There was a problem hiding this comment.
I'm tempted to get rid of these right now, and add them where we dont have ListItem. I have that anyway on my TODO (#6655).
I can't quite answer for list item scope now, I have fully tracked the recent proliferation :)
Wumpf
approved these changes
Jun 27, 2024
5 tasks
abey79
added a commit
that referenced
this pull request
Jun 27, 2024
### What * Builds on #6657 * Part of #6655 This PR is mainly a refactor that abstract the buttons used by `PropertyContent` and `SectionCollapsingHeader`. (This refactor is partial and should also be applied to `LabelContent` -> #6191). This enables action button in section header, used to remove the "edit" button of the entity filter: <img width="356" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/f430805e-2b93-4134-bdbc-fcbbdbbc68e9"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6662?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6662?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6662) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR completely rewrites the existing
large_collapsing_headerstuff as follows:SectionCollapsingHeader.ui.section_collapsing_header("label").ListItem::show_hierarchical_with_children_unindented.Note: the label must now be double-clicked to collapse/uncollapse, as per
ListItembehaviour.Few visible changes beyond the help tooltip. The background no longer changes on hover.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.