Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the blueprint API for styling in the plots example #6781

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jul 5, 2024

What

☝🏻

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added 🐍 Python API Python logging API examples Issues relating to the Rerun examples include in changelog labels Jul 5, 2024
@abey79 abey79 mentioned this pull request Jul 5, 2024
26 tasks
@emilk
Copy link
Member

emilk commented Jul 5, 2024

image

So I assume it looks exactly the same after?

@abey79
Copy link
Member Author

abey79 commented Jul 5, 2024

So I assume it looks exactly the same after?

Yes.

@abey79 abey79 merged commit 5bf0146 into main Jul 5, 2024
34 checks passed
@abey79 abey79 deleted the antoine/update-plots-example branch July 5, 2024 13:30
abey79 added a commit that referenced this pull request Jul 5, 2024
### What

☝🏻 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6781?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6781?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6781)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
emilk added a commit that referenced this pull request Jul 8, 2024
### Next steps
- Test the release
- If this is an 'alpha' release, you can just merge the pull request.
- Otherwise:
  - For any added commits, run the release workflow in 'rc' mode again
- After testing, _ensure that this PR is mergeable to _, then run the
release workflow in 'release' mode
- Once the final release workflow finishes it will create a GitHub
release for you. Then:
    - [x] Sanity check the build artifacts:
      - [x] pip install: does it install and run?
      - [x] cargo install of cli tool: does it install and run?
      - [x] C++ SDK zip: does it contain rerun_c for all platforms?
- [x] Populate the release with the changelog and a nice header
video/picture, check , then click .
- [ ] Make sure the [conda feedstock
PR](https://github.com/conda-forge/rerun-sdk-feedstock/pulls) gets
merged. This will be created by the once the GitHub release is created.
- [x] Update the [google colab
notebooks](https://drive.google.com/drive/folders/0AC0q24MFKh3fUk9PVA)
to install this version and re-execute the notebook.
    - [ ] Merge this PR

### TODO

- [x]  make sure the changelog.md date is correct
- [x] migration guide
- [x] docs update
	- [x] mainly mentions/links to the viz/override docs where appropriate
- [x] remove speculative link markers
  - [x] including all `attr.docs.unreleased`
- [x] cherrypick:
	- [x] #6771
	- [x] #6768
	- [x] #6781
	- [x] #6779
    - [x] #6782
    - [x] #6783
- [x] make sure nothing is left to be cherry-picked
- [x] Tests
  - [x] Windows
  - [x] Linux
  - [x] MacOS

---------

Co-authored-by: Antoine Beyeler <antoine@rerun.io>
Co-authored-by: Antoine Beyeler <49431240+abey79@users.noreply.github.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Jan Procházka <honza.spacir@gmail.com>
Co-authored-by: Andreas Reich <andreas@rerun.io>
Co-authored-by: jprochazk <1665677+jprochazk@users.noreply.github.com>
Co-authored-by: Leonard Bruns <roym899@gmail.com>
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples include in changelog 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants