Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add videos to major releases in CHANGELOG.md #6805

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 8, 2024

Either we always add them or we never add them, but this isn't right.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 📖 documentation Improvements or additions to documentation ⛴ release Related to shipping or publishing exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jul 8, 2024
@emilk emilk changed the title Fix missing media in CHANGELOG.md Add videos to major releases in CHANGELOG.md Jul 8, 2024
@emilk emilk merged commit a353519 into main Jul 8, 2024
34 checks passed
@emilk emilk deleted the cmc/consistent_changelog_media branch July 8, 2024 11:01
teh-cmc added a commit that referenced this pull request Jul 8, 2024
Either we always add them or we never add them, but this isn't right.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6805?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6805?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6805)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants