Fix query benchmarks overflow #6806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🔨 testing
emilk
reviewed
Jul 8, 2024
| @@ -190,7 +190,7 @@ pub fn build_some_strings(len: usize) -> Vec<Text> { | |||
|
|
|||
| (0..len) | |||
| .map(|_| { | |||
| let ilen: usize = rng.gen_range(0..10000); | |||
There was a problem hiding this comment.
So we will see a 100x improvement in benchmark numbers now?
There was a problem hiding this comment.
🤷 It was already not comparable with the old one anyway (and this version never ran successfully).
teh-cmc
added a commit
that referenced
this pull request
Jul 8, 2024
These benchmarks used to be `DataRow`-based, i.e. the rows didn't share any memory. Now that these are `Chunk`-based, the memory for all strings is shared, and therefore cannot be more than 4gig total.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These benchmarks used to be
DataRow-based, i.e. the rows didn't share any memory.Now that these are
Chunk-based, the memory for all strings is shared, and therefore cannot be more than 4gig total.Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.