Rename Material component to AlbedoFactor
#6841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
include in changelog
🪵 Log & send APIs
emilk
changed the title
Material component to AlbedoFactor
Deployed docs
|
emilk
force-pushed
the
emilk/albedo-factor
branch
from
42d2673 to
23a40fb
Compare
emilk
force-pushed
the
emilk/albedo-factor
branch
from
23a40fb to
58d4d78
Compare
emilk
changed the title
Material component to AlbedoFactormesh_materia: Material component to albedo_factor: AlbedoFactor
emilk
changed the title
mesh_materia: Material component to albedo_factor: AlbedoFactorMaterial component to AlbedoFactor
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9871081523 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9872003157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
MaterialintoAlbedoFactorand remove inner nullability #6829This renames the
Materialcomponent toAlbedoFactor, which now simply wraps adatatypes.Rgba32.Consequently, the field
mesh_materialinMesh3Dis now namedalbedo_factorWhen constructing a
Mesh3D:.with_mesh_material(Material::from_albedo_factor(color))->with_albedo_factor(color)mesh_material=rr.Material(albedo_factor=color)->albedo_factor=colorChecklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerraw_meshexamples@rerun-bot full-checkand checked the resultsTo run all checks from
main, comment on the PR with@rerun-bot full-check.