Add Scale3D component #6892
Merged
Add Scale3D component #6892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
do-not-merge
7 tasks
Deployed docs
|
Wumpf
added a commit
that referenced
this pull request
Jul 16, 2024
### What * Part of #6831 * Followed by #6892 Starts the process of splitting up `Transform3D` into several components. Far from done overall, but establishes a lot of the new documentation & test patterns for this effort. This PR fully replaces the `TranslationAndMat3x3` variant & datatype and puts `Translation3D` & `TransformMat3x3` into existence and to work. It does not touch on anything directly related to out of tree transforms and does not do away from the `Transform3D` component yet. I added a new component edit/view ui for consistency: <img width="532" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/1e7122f0-bf27-4f50-bc23-2824c2607ab2"> <img width="552" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/1b30af25-905f-49ed-952b-961350dfab1f"> Unfortunately, transform hierarchy doesn't get affected by overrides yet (see #6743), which is why I had to turn off editing itself for the moment. Also, we don't yet show multiline on hover, so matrix3x3 inspection regressed a little bit for the moment (part of the only partially solved #6661) ### Checklist * [x] pass `main` ci checks * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6866?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6866?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6866) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Base automatically changed from
andreas/translation-and-transformmat3-components
to
main
July 16, 2024 08:01
An error occurred while trying to automatically change base from
andreas/translation-and-transformmat3-components
to
main
July 16, 2024 08:01
… - follows the same model as TranslationRotationScale now
Wumpf
force-pushed
the
andreas/scale3d-component
branch
from
fa8b90d to
3cf3d83
Compare
Wumpf
force-pushed
the
andreas/scale3d-component
branch
from
31293b6 to
490b853
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9957209151 |
|
all test failed with a known issue, otherwise green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Translation3D&TransformMat3x3#6866Introduces a new
Scale3Dcomponent that lives directly on theTransform3Darchetype.The
Scale3Ddatatype which is part ofTranslationRotationScale3Dis still around, but will be removed in a subsequent PR.Additionally, reversed order of how transform components. Rationale: "translation, rotation, scale" is a common way of expressing a simple transform. What is meant is that we first scale an object, then rotate it and then translate it.
Commit by commit review possible.
Checklist
maincimainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.