Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure example .rrd files have description first #7179

Merged
merged 7 commits into from
Aug 14, 2024
Merged

Ensure example .rrd files have description first #7179

merged 7 commits into from
Aug 14, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 14, 2024 •
edited by github-actions bot
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 14, 2024
@emilk
Copy link
Member Author

emilk commented Aug 14, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/10386235473

@teh-cmc teh-cmc self-requested a review August 14, 2024 11:39
teh-cmc
teh-cmc approved these changes Aug 14, 2024
View reviewed changes
crates/store/re_entity_db/src/entity_db.rs Outdated
)
});
let data_messages = {
let mut chunks: Vec<&Arc<Chunk>> = self.store().iter_chunks().collect();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be possible to apply the time filter before collect()

crates/store/re_entity_db/src/entity_db.rs Outdated Show resolved Hide resolved
emilk and others added 4 commits August 14, 2024 14:34
@emilk emilk merged commit 9e50d2c into main Aug 14, 2024
28 checks passed
@emilk emilk deleted the emilk/fix-example-ordering branch August 14, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example .rrds has description last
2 participants
@emilk @teh-cmc