Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example screenshots, improve pinhole example, fix DisconnectedSpace docs #7189

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 14, 2024

What

see title!
Also did some fixes to the screenshot checking utility.

Ran pixi run -e py python ./docs/snippets/compare_snippet_output.py archetypes/pinhole_perspective to check whether changes pass comparison check

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples include in changelog labels Aug 14, 2024
Copy link

Deployed docs

Commit Link
900a4e1 https://landing-nvb8lrat5-rerun.vercel.app/docs

@Wumpf Wumpf merged commit a7392dd into main Aug 15, 2024
43 checks passed
@Wumpf Wumpf deleted the andreas/screenshot-updates branch August 15, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update outdated example screenshots
2 participants