Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct dependency on puffin to 0.19.1, preventing a possible build failure. #7221

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

kpreid
Copy link
Collaborator

@kpreid kpreid commented Aug 16, 2024

What

re_tracing::profile_function_if uses puffin::profile_function_if, which only exists in puffin 0.19.1 and not 0.19.0. This incorrect version would cause a compilation failure for users updating to Rerun 0.18 who already have puffin 0.19.0 in their lock file.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

`re_tracing::profile_function_if` uses `puffin::profile_function_if`,
which only exists in `puffin` 0.19.1 and not 0.19.0. This incorrect
version would cause a compilation failure for users updating to Rerun
0.18 who already have `puffin` 0.19.0 in their lock file.
@kpreid kpreid added dependencies concerning crates, pip packages etc include in changelog labels Aug 16, 2024
@emilk emilk merged commit 123474e into rerun-io:main Aug 17, 2024
32 of 33 checks passed
@kpreid kpreid deleted the puffin branch August 17, 2024 18:57
@emilk emilk added this to the 0.18.1 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants