Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sdk_info.h even if RERUN_INSTALL_RERUN_C option is OFF #7246

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 20, 2024

What

Since rerun 0.18, the C++ public headers now include the rerun/c/sdk_info.h header, so the rerun/c/sdk_info.h file needs to be installed even if the C static library is not installed, i.e. if RERUN_INSTALL_RERUN_C CMake option is set to OFF.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, completely missed that this could be an issue when adding sdk_info.h

@Wumpf Wumpf added 🪳 bug Something isn't working 🌊 C++ API C/C++ API specific include in changelog labels Aug 20, 2024
@Wumpf Wumpf added this to the 0.18.1 milestone Aug 20, 2024
@Wumpf Wumpf merged commit ed70c2a into rerun-io:main Aug 20, 2024
7 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🌊 C++ API C/C++ API specific include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants