Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert most remaining DataUI component implementations to component uis in re_component_ui #7247

Merged
merged 15 commits into from
Aug 22, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 20, 2024

What

what's left is quite compact but rather tricky. I also tried to capture the status quo in some comments and do various cleanup to make it easier for the next person stumbling into the treacherous world of drawing ui for components!

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added ui concerns graphical user interface 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 20, 2024
crates/viewer/re_component_ui/src/line_strip.rs Outdated Show resolved Hide resolved
crates/viewer/re_component_ui/src/line_strip.rs Outdated Show resolved Hide resolved
crates/viewer/re_component_ui/src/view_coordinates.rs Outdated Show resolved Hide resolved
crates/viewer/re_component_ui/src/resolution.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit abfe3df into main Aug 22, 2024
33 of 34 checks passed
@Wumpf Wumpf deleted the andreas/migrate-component-uis branch August 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants