Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gamma (srgb EOTF) for GLTF via Asset3D embedded rgb(a) textures #7251

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 22, 2024

What

Fix gltf loader assuming that the mesh shader doesn't apply the EOTF, when it fact it does (i.e. it calls linear_from_srgb)

Reference - via raw_mesh which was unaffected:
image

Before:
image

After:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

… when it fact it does (i.e. it calls `linear_from_srgb`)
@Wumpf Wumpf added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself include in changelog labels Aug 22, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad!

@emilk emilk added this to the 0.18.1 milestone Aug 22, 2024
@emilk emilk merged commit 69770e8 into main Aug 22, 2024
38 checks passed
@emilk emilk deleted the andreas/fix-gltf-srgb branch August 22, 2024 14:24
@Wumpf
Copy link
Member Author

Wumpf commented Aug 22, 2024

OETF/EOTFing is hard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants