Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Loggable{Batch}::arrow_field #7257

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 23, 2024

It doesn't make any sense for a ComponentBatch to have any say in what the final ArrowField should look like.

An ArrowField is a Chunk/RecordBatch/Schema-level concern that only makes sense during IO/transport/FFI/storage/etc, and which requires external context that a single ComponentBatch on its own has no idea of.


Part of a lot of clean up I want to while we head towards:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🚜 refactor Change the code, not the functionality include in changelog labels Aug 23, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Aug 23, 2024

@rerun-bot full-check

Copy link

@teh-cmc
Copy link
Member Author

teh-cmc commented Aug 23, 2024

@rerun-bot full-check

Copy link

@teh-cmc teh-cmc merged commit e9de566 into main Aug 23, 2024
67 checks passed
@teh-cmc teh-cmc deleted the cmc/get_rid_of_stuff_2 branch August 23, 2024 13:29
@teh-cmc teh-cmc changed the title Remove Loggable{Batch}::arrow_field Remove unused Loggable{Batch}::arrow_field Aug 28, 2024
emilk added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants