Remove unused Loggable{Batch}::arrow_field
#7257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make any sense for a
ComponentBatch
to have any say in what the finalArrowField
should look like.An
ArrowField
is aChunk
/RecordBatch
/Schema
-level concern that only makes sense during IO/transport/FFI/storage/etc, and which requires external context that a singleComponentBatch
on its own has no idea of.Part of a lot of clean up I want to while we head towards:
re_arrow2
toarrow
#3741Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.