Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VisualizerOverrides serializer and improved error handling #7288

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Aug 27, 2024

What

The field-converter ended up misnamed likely during a component type refactor.

  • Add new unit-test for the specific case
  • Add new check for valid field converts.
  • Fix the field converter itself
  • Add a release checklist that uses the override functionality.

Also if VisualizerOverrides is bad, we now handle it more gracefully instead of spamming warnings.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🪳 bug Something isn't working 🐍 Python API Python logging API 📺 re_viewer affects re_viewer itself labels Aug 27, 2024
@jleibs jleibs marked this pull request as ready for review August 27, 2024 20:01
@jleibs jleibs changed the title Fix VisualizerOverrides and improved error handling Fix VisualizerOverrides serializer and improved error handling Aug 27, 2024
@jleibs jleibs added this to the 0.18.1 milestone Aug 27, 2024
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jleibs
Copy link
Member Author

jleibs commented Aug 28, 2024

The bug was in serialization. The old rrd still has the wrong data. This worked for me when running locally.

@teh-cmc
Copy link
Member

teh-cmc commented Aug 28, 2024

The bug was in serialization. The old rrd still has the wrong data. This worked for me when running locally.

Ha! right

@jleibs jleibs merged commit 2c4000c into main Aug 28, 2024
35 of 38 checks passed
@jleibs jleibs deleted the jleibs/fix_7287 branch August 28, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🐍 Python API Python logging API 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VisualizerOverrides broken likely due to same old serialization issue
2 participants