Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle proper half-size splatting semantics in from_mins_and_sizes #7291

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Handle proper half-size splatting semantics in from_mins_and_sizes #7291

merged 1 commit into from
Aug 28, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Aug 27, 2024 •
edited
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added this to the 0.18.1 milestone Aug 27, 2024
@jleibs jleibs marked this pull request as ready for review August 27, 2024 21:29
@jleibs jleibs added 🦀 Rust API Rust logging API include in changelog 🪳 bug Something isn't working labels Aug 27, 2024
@teh-cmc teh-cmc self-requested a review August 28, 2024 06:51
@teh-cmc teh-cmc merged commit 88b19f9 into main Aug 28, 2024
36 of 41 checks passed
@teh-cmc teh-cmc deleted the jleibs/fix_7289 branch August 28, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Milestone
0.18.1
Development

Successfully merging this pull request may close these issues.

Boxes3D::from_mins_and_sizes does not respect Box3D join semantics
2 participants
@jleibs @teh-cmc