Speed up handling of large numbers of transform entities #7300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
changed the title
jleibs
commented
Aug 28, 2024
crates/viewer/re_space_view_spatial/src/transform_component_tracker.rs
Outdated
Show resolved
Hide resolved
teh-cmc
approved these changes
Aug 28, 2024
crates/viewer/re_space_view_spatial/src/transform_component_tracker.rs
Outdated
Show resolved
Hide resolved
crates/viewer/re_space_view_spatial/src/transform_component_tracker.rs
Outdated
Show resolved
Hide resolved
crates/viewer/re_space_view_spatial/src/transform_component_tracker.rs
Outdated
Show resolved
Hide resolved
|
Would you say this: ? |
I'm going to mark it as resolves for now. Just compared release build between 0.18 and o.17 and they both end up in the ballpark of 3.3ms for system execution. |
jleibs
added a commit
that referenced
this pull request
Aug 28, 2024
### What Resolves: #7292 Halves the time spent in `execute_systems` when using many Transforms. - TransformContext uses a store subscriper to track which components are non-empty and only queries those from the store. - Arrows visualizer no longer queries for overrides on the unused transform components since those are fetched from the transform context manager anyways. Before:  After:  ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7300?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7300?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7300) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves: #7292
Halves the time spent in
execute_systemswhen using many Transforms.Before:
After:
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.