Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time crate to 0.3.36, fixing compilation on newer Rust versions #7308

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 29, 2024

cargo +1.80.0 build -p rerun-cli works after this

Checklist

  • I have read and agree to Contributor Guide and the Code of
    Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • Using examples from latest main build: rerun.io/viewer
  • Using full set of examples from nightly build: rerun.io/viewer
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

…ons (#7228)

### What
* Closes #7216

`cargo +1.80.0 build -p rerun-cli` works after this

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7228?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7228?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7228)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@emilk emilk added dependencies concerning crates, pip packages etc 🦟 regression A thing that used to work in an earlier release include in changelog labels Aug 29, 2024
@teh-cmc teh-cmc merged commit 3392b93 into main Aug 29, 2024
34 checks passed
@teh-cmc teh-cmc deleted the emilk/update-time-and-time-again branch August 29, 2024 10:35
teh-cmc pushed a commit that referenced this pull request Aug 29, 2024
…ons (#7308)

* This was done already in #7228
* …but accidentally reverted in
#7226 🤦
* Closes #7216

`cargo +1.80.0 build -p rerun-cli` works after this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc include in changelog 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rerun-cli fails to install due to error in time dependency
2 participants