Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the TimeRangeTableOrder blueprint structure, which is no longer used by the dataframe view #7415

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Remove the TimeRangeTableOrder blueprint structure, which is no longer used by the dataframe view #7415

merged 1 commit into from
Sep 16, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Sep 12, 2024 •
edited by github-actions bot
Loading

What

What the title says☝🏻 This was dead code and a wart in the dataframe view selection panel.

Table sorting is now covered by #7070 and blocked on proper support at re_dataframe level.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface feat-dataframe-view Everything related to the dataframe view exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality labels Sep 12, 2024
@emilk emilk self-requested a review September 16, 2024 08:07
@emilk emilk merged commit c8855c7 into main Sep 16, 2024
43 checks passed
@emilk emilk deleted the antoine/remove-dataframe-table-order branch September 16, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-view Everything related to the dataframe view 🚜 refactor Change the code, not the functionality ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "Time range table order" view settings
2 participants
@abey79 @emilk