Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullptr check when forwarding from component to datatype #7430

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Sep 16, 2024

What

We already have a similar check in our builders, but when a component forwards to the datatype builder, we need a similar check.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs marked this pull request as ready for review September 16, 2024 17:19
@jleibs jleibs force-pushed the jleibs/nullptr_check_component_forward branch from 5fd1e50 to d731345 Compare September 16, 2024 17:42
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest iteration lgtm!
Unforunate that it makes the forwarding so much longer, but don't have a good idea how to avoid that right now (other than some weird macro).

@Wumpf Wumpf merged commit 4faea26 into main Sep 17, 2024
38 checks passed
@Wumpf Wumpf deleted the jleibs/nullptr_check_component_forward branch September 17, 2024 07:40
@emilk emilk changed the title Codegen a nullptr check when forwarding from component to datatype Codegen a nullptr check when forwarding from component to datatype Oct 16, 2024
@emilk emilk changed the title Codegen a nullptr check when forwarding from component to datatype Add nullptr check when forwarding from component to datatype Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants