Update to latest mp4 rev
#7470
Merged
Update to latest mp4 rev
#7470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
added
exclude from changelog
Wumpf
requested changes
Sep 23, 2024
| VideoFrame(frame), | ||
| )); | ||
| let composition_timestamp = | ||
| Time::from_micros(frame.timestamp().unwrap_or(0.0), timescale); |
There was a problem hiding this comment.
this was TimeMs::new(frame.timestamp().unwrap_or(0.0)), before but now we interpret the timestamp as microseconds where we assumed milliseconds before. That looks like a bug!
There was a problem hiding this comment.
That's intentional, the value returned here is the same as the one passed in when we create the EncodedVideoChunk. We want to match video-decode-test behavior more closely (because it Just Works ™️), and it uses microseconds as well, so I switched to using microseconds here:
There was a problem hiding this comment.
Note that the VideoFrame API guarantees that the values passed in are the same as the ones passed out
Wumpf
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
mp4to the latest commit on https://github.com/rerun-io/re_mp4/tree/jan/fixesWe should land the following PR first:
(we can leave that one be and land this, but then we'd have to update the
revagain once that lands)Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.