Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused nox dev dependency & mentions #7508

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 25, 2024

What

We stopped using nox for python testing quite a while ago.

Checklist

  • pass main ci
  • confirm that pixi run py-test works fine locally
  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Sep 25, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Sep 25, 2024

@rerun-bot full-check

Copy link

Deployed docs

Commit Link
fdacc35 https://landing-5890zn2io-rerun.vercel.app/docs

Copy link

".pixi",
"build"
],

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto formatter wanted those newlines to be gone, who am I to judge

@Wumpf Wumpf marked this pull request as ready for review September 25, 2024 09:40
@Wumpf Wumpf requested a review from abey79 September 25, 2024 09:40
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up—and for reminding me of the sorry state of our testing against python version 😅

@Wumpf
Copy link
Member Author

Wumpf commented Sep 25, 2024

reminding me of the sorry state of our testing against python version

aaaany time! ;)

@Wumpf Wumpf merged commit 199e4b1 into main Sep 25, 2024
76 of 77 checks passed
@Wumpf Wumpf deleted the andreas/remove-nox-mentions branch September 25, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace nox by pixi
2 participants