Support h.264 video decoding on web #7511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the lint failure comes from main |
Wumpf
approved these changes
Sep 26, 2024
Comment on lines
+220
to
+224
| // Some terminology: | ||
| // - presentation timestamp = composition timestamp | ||
| // = the time at which the frame should be shown | ||
| // - decode timestamp | ||
| // = determines the decoding order of samples |
There was a problem hiding this comment.
good call to document that here, makes this stuff a lot more maintainable 👍
|
|
||
| // 2. Search _backwards_, starting at `decode_sample_idx`, looking for | ||
| // the first sample where `sample.composition_timestamp <= presentation_timestamp`. | ||
| // This is the sample the user requested. |
There was a problem hiding this comment.
nit: "uhm, actually" the user technically doesn't request a sample. A single sample is not able to represent the user's request
... but I don't know how to describe it better either right now. Fine to leave it this way I think
There was a problem hiding this comment.
Changed it to "This is the sample which when decoded will be presented at the timestamp the user requested."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
re_video#7375EncodedVideoChunks are now given the composition timestamp of the sample instead of its decode timestamp, so the outputVideoFrameobjects are in composition timestamp order.Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.