-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate hub-wide caches on deletions and overwrites #7525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice
looking forward to making the caches more of a store aware thing so we can streamline some of the quasi-copy-pasted code here, but this will do for now; at least it's flexible enough (via being very stupid/simple) to deal with fallbacks & blueprint shenanigans.
(that's pretty much what you mean when complaining about the lack of secondary caches, right?)
A real secondary cache would be aware of query semantics, and any shadowing introduced by these semantics, which is way more powerful and capable than working with row-ids directly. E.g.:
None of those are possible when working with row-ids directly. |
Co-authored-by: Andreas Reich <andreas@rerun.io>
|
Hub-wide caches now subscribe to store events and invalidate accordingly in the face of deletions and overwrites.
This is a crutch to compensate for the lack of secondary caching, but a much needed crutch: the Rerun Viewer can now effectively be used as a soft realtime telemetry system.
24-09-26_18.23.02.patched.mp4
Checklist
EncodedImage
Before: 🟥
After: 🟢
Mesh3D
Before: 🟥
After: 🟢
Asset3D
Before: 🟥
After: 🟢
TensorData
Before: 🟥
After: 🟢
AssetVideo
Before: 🟥
After: 🟢
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.