Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe view update and blueprint API (part 2): UI for the query #7527

Open
wants to merge 10 commits into
base: antoine/dfv1-new-query-fbs
Choose a base branch
from

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Sep 26, 2024

What

This PR adds a wrapper over the query view property introduced in #7516 and implement the selection panel UI for it. This UI is functional (e.g. filter event entity and component auto-suggestion, etc.), but it is still ignored by the view itself.

TODO: screenshot


Part of a series to address #6896, #7498, and #7494

All PRs:

  • TODO

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Copy link

Deployed docs

Commit Link
347c3e4 https://landing-7dp96lecs-rerun.vercel.app/docs

@abey79 abey79 added ui concerns graphical user interface feat-dataframe-view Everything related to the dataframe view do-not-merge Do not merge this PR labels Sep 26, 2024
@abey79 abey79 changed the base branch from main to antoine/dfv1-new-query-fbs September 27, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge this PR feat-dataframe-view Everything related to the dataframe view include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant