Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe view update and blueprint API (part 3): use the new query object for column visibility #7545

Draft
wants to merge 2 commits into
base: antoine/dfv2-query-ui
Choose a base branch
from

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Sep 27, 2024

What

This PR wires the column visibility code to the new query object, and cleans up the old code and related blueprint object. At this point the dataframe view is in this weird spot where the old ui is used for everything but column visibility.


Part of a series to address #6896, #7498, and #7494

All PRs:

  • TODO

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.
…code

@abey79 abey79 added do-not-merge Do not merge this PR feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface 🚜 refactor Change the code, not the functionality include in changelog labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge this PR feat-dataframe-view Everything related to the dataframe view include in changelog 🚜 refactor Change the code, not the functionality ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant