Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk store: support for overlapped range queries #7586

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 3, 2024

Turns out I never got around to implementing support for overlapped chunks in range queries in the ChunkStore.

I only realized after hunting down a crazy bug in the dataframe APIs for way too long...

The fix is the exact same as the one used for latest-at queries. In fact it is a copy paste.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc merged commit 82eb7b0 into main Oct 4, 2024
36 checks passed
@teh-cmc teh-cmc deleted the cmc/overlapped_ranges_support branch October 4, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog ⛃ re_datastore affects the datastore itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants