Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug assertion in create_labels #7639

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 8, 2024

What

glam on debug now notices that what we have here is a perspective transform. We actually don't quite care about the perspective divide here, but this fixes the issue and still has the correct label ordering (just to be sure I checked with the spiral of labels generated by the old test_api script)

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 8, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Oct 9, 2024

I need this, merging without review because it's so trivial

@Wumpf Wumpf merged commit e952502 into main Oct 9, 2024
36 of 37 checks passed
@Wumpf Wumpf deleted the andreas/fix-debug-assert branch October 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant