Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating "Navigating the viewer" #7757

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Updating "Navigating the viewer" #7757

merged 11 commits into from
Oct 16, 2024

Conversation

gavrelina
Copy link
Member

@gavrelina gavrelina commented Oct 15, 2024 •
edited by Wumpf
Loading

Updating screenshots and editing a few paragraphs for Navigating the Viewer page.

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Deployed docs

Commit Link
592cbe8 https://landing-pj0gvbwt8-rerun.vercel.app/docs

@gavrelina gavrelina force-pushed the katya/update-the-viewer-docs branch from 84274e1 to 71dcc8e Compare October 15, 2024 20:01
@gavrelina gavrelina added 📖 documentation Improvements or additions to documentation include in changelog labels Oct 16, 2024
@gavrelina gavrelina marked this pull request as ready for review October 16, 2024 10:07
@Wumpf Wumpf self-requested a review October 16, 2024 13:41
Wumpf
Wumpf approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, a lot better!
added some suggestions. Screenshots need updating again but looks good to me otherwise!

docs/content/getting-started/navigating-the-viewer.md Outdated Show resolved Hide resolved
docs/content/getting-started/navigating-the-viewer.md Show resolved Hide resolved
docs/content/getting-started/navigating-the-viewer.md Outdated Show resolved Hide resolved
docs/content/getting-started/navigating-the-viewer.md Outdated Show resolved Hide resolved
docs/content/getting-started/navigating-the-viewer.md Outdated Show resolved Hide resolved
docs/content/getting-started/navigating-the-viewer.md Outdated Show resolved Hide resolved
docs/content/getting-started/navigating-the-viewer.md Show resolved Hide resolved
Wumpf
Wumpf approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Wumpf Wumpf merged commit d311acd into main Oct 16, 2024
30 of 35 checks passed
@Wumpf Wumpf deleted the katya/update-the-viewer-docs branch October 16, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavrelina @Wumpf