Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward CMAKE_TOOLCHAIN_FILE to arrow build for sdk cross-compilation #7866

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

SunDoge
Copy link
Contributor

@SunDoge SunDoge commented Oct 22, 2024

What

Add -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE} to the cmake file to fix #7445

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added this to the Next patch release milestone Oct 22, 2024
@Wumpf Wumpf changed the title Specify the toolchain file for cpp sdk cross-compilation Foward CMAKE_TOOLCHAIN_FILE to arrow build for sdk cross-compilation Oct 22, 2024
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@emilk
Copy link
Member

emilk commented Oct 23, 2024

@SunDoge
Copy link
Contributor Author

SunDoge commented Oct 23, 2024

Will this close

* [Rerun C++ SDK: undefined symbols (arch mismatch) when cross-compiling for macOS x64 #7248](https://github.com/rerun-io/rerun/issues/7248)

?

Unfortunately no. I've tested on my macbook pro.

@Wumpf Wumpf merged commit 246c1fb into rerun-io:main Oct 23, 2024
30 of 32 checks passed
@Wumpf Wumpf changed the title Foward CMAKE_TOOLCHAIN_FILE to arrow build for sdk cross-compilation Forward CMAKE_TOOLCHAIN_FILE to arrow build for sdk cross-compilation Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to cross compile arrow_cpp in rerun_cpp_sdk
3 participants