Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Menu > Import and associated command #7882

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Implement Menu > Import and associated command #7882

merged 1 commit into from
Oct 25, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 23, 2024

The last missing piece in the "open data in-place" story.

It does what you think it does: Menu > Import is like Menu > Open, but imports the data in the current recording rather than create a new one.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added enhancement New feature or request 📺 re_viewer affects re_viewer itself do-not-merge Do not merge this PR include in changelog labels Oct 23, 2024
Base automatically changed from cmc/fwd_opened_id to main October 24, 2024 11:33
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Oct 25, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 25, 2024

I interpret that silence as "no objections" 🙃

@teh-cmc teh-cmc merged commit 97c37a3 into main Oct 25, 2024
35 of 36 checks passed
@teh-cmc teh-cmc deleted the cmc/import branch October 25, 2024 09:12
teh-cmc added a commit that referenced this pull request Oct 25, 2024
By popular demand.

* Fixes #7858
* DNM: requires #7882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant