Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too short picking ray in pinhole-only scenarios #7899

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 24, 2024

What

Details in the code comment.
I tried at first fixing the lack of contribution to the bounding box but then realized that this is a can of worms.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working include in changelog labels Oct 24, 2024
@Wumpf Wumpf merged commit 60724a7 into main Oct 25, 2024
36 of 37 checks passed
@Wumpf Wumpf deleted the andreas/fix-ray-cut-short branch October 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants