Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the python package to support python 3.13, update C++ arrow to 18.0.0 #7930

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 29, 2024

What

Also bumps our pixi arrow version to 18 since this is required for python 3.13 and I want it to get tested.

Bump our C++ arrow library to match.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs changed the title Let our package work with python 3.13 [python] Update the python package to support python 3.13 Oct 29, 2024
@jleibs jleibs added 🐍 Python API Python logging API dependencies concerning crates, pip packages etc labels Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

Deployed docs

Commit Link
53c4592 https://landing-jro2qzbp1-rerun.vercel.app/docs

@jleibs jleibs marked this pull request as ready for review October 29, 2024 16:03
@jleibs
Copy link
Member Author

jleibs commented Oct 29, 2024

@rerun-bot full-check

Copy link

@Wumpf Wumpf self-requested a review October 29, 2024 16:35
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested pixi run cpp-build-all on windows & mac: works on Mac but I get linker errors on Windows now. Looking into it

(marked request changes for that reason)

pixi.toml Outdated
@@ -390,7 +390,7 @@ cpp-build-all-shared-libs = { cmd = "cmake --build build/debug --config Debug --
"cpp-prepare-shared-libs",
] }
cpp-clean = "rm -rf build CMakeCache.txt CMakeFiles"
cpp-build-tests = { cmd = "cmake --build build/debug --config Debug --target rerun_sdk_tests", depends_on = [
cpp-build-tests = { cmd = "cmake --build build/debug --config Release --target rerun_sdk_tests", depends_on = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why switch to release here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that was an accident -- I was curious if Release vs Debug might influence the symbols exposed to the linker when I was running tests.

@Wumpf Wumpf changed the title [python] Update the python package to support python 3.13 Update the python package to support python 3.13, update C++ arrow to 18.0.0 Oct 29, 2024
@Wumpf Wumpf added the 🌊 C++ API C/C++ API specific label Oct 29, 2024
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean build (pixi run cpp-clean) fixed it!

@jleibs jleibs merged commit 380a42d into main Oct 30, 2024
42 checks passed
@jleibs jleibs deleted the jleibs/py13 branch October 30, 2024 12:16
@@ -22,7 +22,7 @@ dependencies = [
description = "The Rerun Logging SDK"
keywords = ["computer-vision", "logging", "rerun"]
name = "rerun-sdk"
requires-python = ">=3.8, <3.13"
requires-python = ">=3.8, <3.14"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to:

Suggested change
requires-python = ">=3.8, <3.14"
requires-python = ">=3.8"

As I explain here, this is often preferred.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hgaiser thanks for reminding me about this. Feedback accepted :)

#7949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific dependencies concerning crates, pip packages etc include in changelog 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for python 3.13
3 participants