-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the python package to support python 3.13, update C++ arrow to 18.0.0 #7930
Conversation
Deployed docs
|
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/11578055123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested pixi run cpp-build-all
on windows & mac: works on Mac but I get linker errors on Windows now. Looking into it
(marked request changes for that reason)
pixi.toml
Outdated
@@ -390,7 +390,7 @@ cpp-build-all-shared-libs = { cmd = "cmake --build build/debug --config Debug -- | |||
"cpp-prepare-shared-libs", | |||
] } | |||
cpp-clean = "rm -rf build CMakeCache.txt CMakeFiles" | |||
cpp-build-tests = { cmd = "cmake --build build/debug --config Debug --target rerun_sdk_tests", depends_on = [ | |||
cpp-build-tests = { cmd = "cmake --build build/debug --config Release --target rerun_sdk_tests", depends_on = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why switch to release here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, that was an accident -- I was curious if Release vs Debug might influence the symbols exposed to the linker when I was running tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean build (pixi run cpp-clean
) fixed it!
@@ -22,7 +22,7 @@ dependencies = [ | |||
description = "The Rerun Logging SDK" | |||
keywords = ["computer-vision", "logging", "rerun"] | |||
name = "rerun-sdk" | |||
requires-python = ">=3.8, <3.13" | |||
requires-python = ">=3.8, <3.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to:
requires-python = ">=3.8, <3.14" | |
requires-python = ">=3.8" |
As I explain here, this is often preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What
Also bumps our pixi arrow version to 18 since this is required for python 3.13 and I want it to get tested.
Bump our C++ arrow library to match.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.