Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional information about decoded frames in the viewer #7932

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 29, 2024

What

image

Minimized by default.

Originally, I wanted to add some more information from the get-go like i/idr/p/b-frame type but turns out we don't really have all that much information around today for sure - a big part of this is that typically just pass in chunks to decoder and get 0-1 frames out for each chunk (my current understand is that it could be 0-n, but n>1 typically doesn't make sense because a single mp4 sample has a single timestamp!). Meaning we typically don't maintain the chunk/frame relationship.
However, this adjusted structure should make it easy to expose optional fields on FrameInfo to forward all sort of things

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

crates/store/re_video/src/decode/mod.rs Show resolved Hide resolved
crates/viewer/re_data_ui/src/blob.rs Outdated Show resolved Hide resolved
crates/viewer/re_data_ui/src/blob.rs Outdated Show resolved Hide resolved
crates/viewer/re_data_ui/src/blob.rs Outdated Show resolved Hide resolved
is_pending,
show_spinner,
frame_info: _, // TODO(emilk): maybe add to `PickableTexturedRect` and `PickingHitType::TexturedRect` so we can show on hover?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this would be nice! :)

@Wumpf Wumpf merged commit 413f7a1 into main Oct 30, 2024
34 of 36 checks passed
@Wumpf Wumpf deleted the andreas/additional-frame-information branch October 30, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants