Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially deprecate support for python 3.8 #7933

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 29, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🐍 Python API Python logging API dependencies concerning crates, pip packages etc labels Oct 29, 2024
@jleibs jleibs marked this pull request as ready for review October 29, 2024 16:14
Copy link

Deployed docs

Commit Link
218dcff https://landing-3p9rs71x1-rerun.vercel.app/docs

@Wumpf Wumpf self-requested a review October 29, 2024 16:34
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!
haven't tried whether the warning triggers myself, but I trust you did :)

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Just to be sure, do users have a means to silence those warning? They could be very annoying for a (still legitimate) use under 3.8. (Or do we think this barely happens anyways?)

@jleibs
Copy link
Member Author

jleibs commented Oct 29, 2024

Python actually silences deprecation warnings by default in most user-facing contexts, which is a bit annoying and practically reduces the chances it will be seen by the users in practice, but that's the policy and I'm not going to fight it or workaround it.

Regardless, this is the "most right" way to handle it. If you enable deprecation warnings in your project config you'll see it, otherwise it won't be visible.

@jleibs
Copy link
Member Author

jleibs commented Oct 29, 2024

Also worth noting that when we drop support, the new wheels will list their incompatibility so people installing will just get an older version or a pypi error if they try to install an explicit version in a 3.8 context.

@jleibs jleibs merged commit dcddc0d into main Oct 30, 2024
36 of 43 checks passed
@jleibs jleibs deleted the jleibs/deprecate_py38 branch October 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc include in changelog 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communicate that python 3.8 support is deprecated
3 participants