Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement usual hover and selection interactions in the map view #7938

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Oct 29, 2024

What

This PR adds the "usual" UI interactions to the map view, including:

  • hover highlight
  • click to select instance
  • cmd-click to add instance to selection
  • double-click to select entire entity
  • click anywhere else in the map view to select the view
  • hover tooltip for the instances

Note: the rendering of the selection/hover silhouette requires a whole bunch of draw passes, which clearly highlights (pun not intended) the need to eventually transit to using re_renderer.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added enhancement New feature or request ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view labels Oct 29, 2024
@emilk emilk self-requested a review October 30, 2024 08:21
abey79 and others added 2 commits October 30, 2024 09:29
@abey79 abey79 mentioned this pull request Oct 30, 2024
27 tasks
@abey79 abey79 merged commit d3539dd into main Oct 30, 2024
35 checks passed
@abey79 abey79 deleted the antoine/geopoint-hover-select branch October 30, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants