-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support H.264 on native via user installed ffmpeg executable #7962
Merged
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
2e1d748
Initial ffmpeg H.264 support in frames example
emilk a06107e
Actual H.264 video playback inside of Rerun viewer
emilk 770f24c
Fix timestamps and seeking
emilk ab3d52a
Code cleanup and better error handling
emilk b25a539
Better error handling
emilk 32c5846
Improve log output and thread names
emilk 32b6739
reduce ffmpeg decode delay
Wumpf 19fe5d0
fix re_video example build
Wumpf e4d3740
add decode timestamp, nal header parsing, various comments, todo notes
Wumpf 6aa8693
better timestamp syncing strategy?
Wumpf 84d0a55
make ffmpeg an async decoder
Wumpf 4897f19
set fps mode to passthrough
Wumpf f8c70fc
comments & debug output
Wumpf edceed6
crude reset implementation
Wumpf 3f21b3d
fix frame reordering
Wumpf 556910b
Merge remote-tracking branch 'origin/main' into andreas/ffmpeg-decoder-2
Wumpf 67843f7
expose DTS through frame info
Wumpf 3e59ee1
handle ffmpeg process lifecycle, handle backward seeks
Wumpf 88b62a5
turn around scheduling & threading strategy again to make things snap…
Wumpf 471e4c5
add access unit delimiter units
Wumpf 4d2ebaf
fix long wait time for ffmpeg shutdown/reset
Wumpf 8f71b5c
fixup webcodecs
Wumpf 415bd09
document the meaning of a video sample better
Wumpf 10abb11
fix lints, handle all ffmpeg events
Wumpf 7e1fc90
The ultimate source on nal headers is unfortunately gone, no point in…
Wumpf b995197
remove old todo
Wumpf 92c1c75
Merge remote-tracking branch 'origin/main' into andreas/ffmpeg-decoder-2
Wumpf 2fdb06c
various improvement to ffmpeg error handling
Wumpf 2858c00
more comment improvements
Wumpf 5025f3b
utility method for writing to stream with mapped error
Wumpf 8a43e24
hide banner (reduce log spam), easier to read frame info reordering
Wumpf 53fff85
fix logspam on seeking
Wumpf 6743ced
fix decode timestamp warning being the wrong way round
Wumpf 696ea49
hover tooltips
Wumpf e2dc61e
make ffmpeg warnigns warn_once, fix swscalar message showing up a lot…
Wumpf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
handle ffmpeg process lifecycle, handle backward seeks
- Loading branch information
commit 3e59ee143575e8e2359f8c9ee6d41e7ee4fb7711
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you hit this path ever? What kind of errors do we find here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never hit it so far, no. I need to try proper broken data!